Run tests in the project dir instead of temp dir in run-tests.sh

[0xNeshi]

No description provided.

[github-actions]

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our guardians team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/guardians)

[IsaacG]

What's the rationale for avoiding a temp dir? Why would you want this change?

[0xNeshi]

What's the rationale for avoiding a temp dir? Why would you want this change?

• avoid unnecessary whole exercise copy/pastes
• avoid dir creation/cleanup
• simplify bash script a bit

Do you think it's worth keeping as-is?

[IsaacG]

What's the rationale for avoiding a temp dir? Why would you want this change?

• avoid unnecessary whole exercise copy/pastes
• avoid dir creation/cleanup
• simplify bash script a bit

Do you think it's worth keeping as-is?

I think it's worth having the justification in the commit description ;)

The copy/paste and directory create/delete is very low impact/cost. Having those in there isn't a big deal. But it's also entirely fine to clean them up if they're not needed. Given that it's not obvious what the benefit of this PR is, it's nice to take a moment to fill in the PR with the reasoning for future readers.

[IsaacG]

https://exercism.org/docs/building/tooling/test-runners/interface says

A path to an input directory (with a trailing slash) containing the submitted solution file(s) and any other exercise file(s). This directory should be considered as read-only. It's technically possible to write into it but it's better to use /tmp for temporary files (e.g. for compiling sources).

@0xNeshi

[0xNeshi]

https://exercism.org/docs/building/tooling/test-runners/interface says

A path to an input directory (with a trailing slash) containing the submitted solution file(s) and any other exercise file(s). This directory should be considered as read-only. It's technically possible to write into it but it's better to use /tmp for temporary files (e.g. for compiling sources).

@0xNeshi

Do you think it makes sense to revert this PR commit?

[0xNeshi]

@IsaacG pinging you in case you missed the last message

[IsaacG]

Do you think it makes sense to revert this PR commit?

Yes.