Skip to content
This repository was archived by the owner on Jan 29, 2021. It is now read-only.

adding current action to cli, to display current assignments for users#80

Merged
kytrinyx merged 7 commits intoexercism:masterfrom
kevinleugers:cli_add_current
Sep 24, 2013
Merged

adding current action to cli, to display current assignments for users#80
kytrinyx merged 7 commits intoexercism:masterfrom
kevinleugers:cli_add_current

Conversation

@kevinleugers
Copy link
Copy Markdown
Contributor

API endpoint is in place already for /user/assignments/current. Addressing exercism.io issue #205 to add the ability to see current assignments from the cli.

@kytrinyx
Copy link
Copy Markdown
Member

The build is failing on this one. Is there a missing VCR cassette?

@kevinleugers
Copy link
Copy Markdown
Contributor Author

Yes, there is actually. I develop on windows using a Linux VM, so my localhost is actually the IP address of my VM session.

I was afraid the cassette would cause problems with the IP address in there so I just rememoved it thinking it would be generated again.

I hope that makes sense. I suppose I could just edit the cassette file after the fact so it points to localhost?

@kytrinyx
Copy link
Copy Markdown
Member

Ah, got it. The CI server doesn't regenerate it -- I'd have to do that locally. I don't think it matters where it points, actually, though it's probably a good idea to edit it to point at whatever the other cassettes point to for consistency.

@kevinleugers
Copy link
Copy Markdown
Contributor Author

Should be good to merge now :)

@kytrinyx
Copy link
Copy Markdown
Member

kytrinyx commented Sep 3, 2013

Would you mind merging master into the branch?

Comment thread lib/cli.rb
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out String#ljust

@markijbema
Copy link
Copy Markdown
Contributor

Cool, nice functionality :)

@kevinleugers
Copy link
Copy Markdown
Contributor Author

@mikegee thanks! That's exactly what I needed there. @markijbema good catch, thank you.

@kytrinyx
Copy link
Copy Markdown
Member

Sorry -- I keep missing this.

Would you mind merging in master again, and leaving a note in the discussion thread so that I am certain to see it?

@kevinleugers
Copy link
Copy Markdown
Contributor Author

Sure! No problem. Will reply back when finished.

@kevinleugers
Copy link
Copy Markdown
Contributor Author

@kytrinyx I believe this is ready now. Thanks!

kytrinyx added a commit that referenced this pull request Sep 24, 2013
adding current action to cli, to display current assignments for users
@kytrinyx kytrinyx merged commit c905c83 into exercism:master Sep 24, 2013
@kytrinyx
Copy link
Copy Markdown
Member

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants