Skip to content

Add additional "can fail" and "timeout" fields to task groups #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

eramongodb
Copy link
Collaborator

Refer to the Task Groups section of the "Project Configuration Files" page.

evergreen validate rejects a *_timeout_secs field of type str:

task_groups:
  - name: example
    setup_group_timeout_secs: "123"
ERROR: load project error(s): loading file '[...]': error unmarshalling yaml strict: yaml: unmarshal errors:
  line 3: cannot unmarshal !!str `123` into int

The field types therefore updated from Optional[Union[int, str]] to Optional[int] accordingly.

@eramongodb eramongodb requested a review from a team as a code owner October 18, 2024 14:30
@eramongodb eramongodb requested review from aldo-aguilar and namazgurbanovmdb and removed request for a team October 18, 2024 14:30
setup_group: Optional[List[EvgCommand]] = None
teardown_group_can_fail_task: Optional[bool] = None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this to the class doc as well? Also, out of curiousity, is there timeout_specs for teardown_group?

Copy link
Collaborator Author

@eramongodb eramongodb Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this to the class doc as well?

Apologies, teardown_group_can_fail_task is actually undocumented and invalid according to the EVG validator (which is a surprise to me). Filed DEVPROD-12438 (fixed link) and commented it out for now (similar approach to #40).

Is there timeout_secs for teardown_group?

Yes, there is a teardown_group_timeout_secs. Added for completeness.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEVPROD-12438 clarified teardown_group_can_fail_task is deliberately unsupported due to implementation concerns and there are no plans to support it either. Removed the field entirely accordingly.

Copy link
Collaborator

@namazgurbanovmdb namazgurbanovmdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eramongodb
Copy link
Collaborator Author

This PR recieved a LGTM several weeks ago but has not yet been merged. Is this blocked on anything?

@zituo-jin zituo-jin added this pull request to the merge queue Nov 11, 2024
@zituo-jin zituo-jin removed this pull request from the merge queue due to a manual request Nov 11, 2024
@zituo-jin zituo-jin added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 11, 2024
@zituo-jin zituo-jin enabled auto-merge November 12, 2024 01:42
@zituo-jin zituo-jin added this pull request to the merge queue Nov 12, 2024
Merged via the queue into evergreen-ci:main with commit 87a0b5a Nov 12, 2024
2 checks passed
@eramongodb eramongodb deleted the shrub-task-groups branch November 12, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants