-
Notifications
You must be signed in to change notification settings - Fork 5
Add additional "can fail" and "timeout" fields to task groups #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/shrub/v3/evg_task_group.py
Outdated
setup_group: Optional[List[EvgCommand]] = None | ||
teardown_group_can_fail_task: Optional[bool] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this to the class doc as well? Also, out of curiousity, is there timeout_specs for teardown_group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this to the class doc as well?
Apologies, teardown_group_can_fail_task
is actually undocumented and invalid according to the EVG validator (which is a surprise to me). Filed DEVPROD-12438 (fixed link) and commented it out for now (similar approach to #40).
Is there timeout_secs for teardown_group?
Yes, there is a teardown_group_timeout_secs
. Added for completeness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEVPROD-12438 clarified teardown_group_can_fail_task
is deliberately unsupported due to implementation concerns and there are no plans to support it either. Removed the field entirely accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR recieved a LGTM several weeks ago but has not yet been merged. Is this blocked on anything? |
Refer to the Task Groups section of the "Project Configuration Files" page.
evergreen validate
rejects a*_timeout_secs
field of typestr
:The field types therefore updated from
Optional[Union[int, str]]
toOptional[int]
accordingly.