Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
was thinking of checking kotlin-inject for migration of my android project into KMP and then I saw #486 and figured I can do the simple stuff of building initial setup of Github actions and let you take care of the publishing and other complex stuff.
Admittedly I do not know the other stuff and I only did what I know that I can do
Changes made with this PR
main
branch or in apull_request
. Can also manually building at the actions tabmacos
andubuntu
can run in parallel.fail-fast: false
so if the other fails it won't immediately result in the other to be cancel out due to the build failuregradle-wrapper-validation
for validating you got true gradle wrapper https://github.com/gradle/actions/blob/main/docs/wrapper-validation.md#gradle-wrapper-validation-actionsetup-gradle
was added so you can cache the build. By default it will only cache the default branch and other branches will only be a read only to it https://github.com/gradle/actions/blob/main/docs/setup-gradle.md#using-the-cache-read-onlyI also made another workflow for lint check. This one will always run on all of the commits in the
pull request
and pushes tomain
branchI personally like the separation of the
build
and a lintcheck
so that you could track each separatelyI did not add dependabot as you might be thinking of other ci for example like renovate but if you do this is the simple code for it
.github/dependabot.yml