Fix NullReferenceException if one provides fake url as a server#42
Open
trams wants to merge 1 commit intoetsy:masterfrom
Open
Fix NullReferenceException if one provides fake url as a server#42trams wants to merge 1 commit intoetsy:masterfrom
trams wants to merge 1 commit intoetsy:masterfrom
Conversation
Contributor
|
Not a bad idea here. iirc at Etsy it was handy to fail fast if someone deployed with a bad server URL we might not want to mask that completely, but could handle it better than NPE. Any thoughts about doing something in between? Any Etsy folks have input on this? |
Contributor
Author
|
I am okay with either solution. We could throw a distinct exception instead of NPE |
Contributor
|
My instinct is a better error message would be the play here, but I'll defer to the Etsy folks to decide that as they can merge. Nice find, thanks for the contrib! |
Contributor
|
@trams Thanks for your contribution! We'd love to add a distinct exception/informative error message, as @initialcontext suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.