-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Matomo & AI consent dialog #6060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
4317b79
to
7232ece
Compare
@@ -36,6 +36,7 @@ export default class SettingsTab extends ViewPlugin { | |||
} | |||
element: HTMLDivElement | |||
public useMatomoAnalytics: any | |||
public useMatomoPerfAnalytics: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we can add basic types and avoid any going forward? Any should be reserved for completely unresolvable situations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
dabc990
to
c3d51f7
Compare
c3d51f7
to
1299dce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes #5832