eth/vm/logic/system: fix CREATE2 failures on BadOpcode test fixture #1560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 COMMITS SQUASHED: eth/vm/logic/system: CREATE2 consumes the fixed 32000 gas that CREATE does. For reference, EIP-1014: https://eips.ethereum.org/EIPS/eip-1014 eth/vm/logic/system: increment nonce in CREATE2 (was missing).
This was referenced Dec 7, 2018
cburgdorf
approved these changes
Dec 8, 2018
|
|
||
| def generate_contract_address(self, | ||
| stack_data: CreateOpcodeStackData, | ||
| call_data: bytes, | ||
| computation: BaseComputation) -> Address: | ||
|
|
||
| computation.state.account_db.increment_nonce(computation.msg.storage_address) |
There was a problem hiding this comment.
You are the man! 👍 I must have missed that detail in the spec. Thanks for helping out with this 🙏
There was a problem hiding this comment.
Heh. Sorry for making so much noise out of one missing line. ^_^
BTW, the detail is only implicit in the "Behaves identically to CREATE", so easy to skip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
CREATE2does not match the spec, EIP-1014.PR #1181 was therefore failing fixtures.
How was it fixed?
Use missing gas amount of 32000 (as
CREATEdoes); increment nonce.Cute Animal Picture
Source: unknown; found here