Add eth_config
#32239
Open
Add eth_config
#32239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
requested review from
fjl,
gballet,
rjl493456442,
zsfelfoldi and
s1na
as code owners
|
|
||
| switch { | ||
| case c.IsOsaka(london, time): | ||
| next = c.OsakaTime |
There was a problem hiding this comment.
Wouldn't it be better to return something like Maxuint64 here
| @@ -1135,6 +1135,34 @@ func (api *BlockChainAPI) CreateAccessList(ctx context.Context, args Transaction | |||
| return result, nil | |||
| } | |||
|
|
|||
| type config struct { | |||
| ActivationTime uint64 `json:"activationTime"` | |||
| BlobSchedule *params.BlobConfig `json:"blobSchedule"` | |||
There was a problem hiding this comment.
Suggested change
| BlobSchedule *params.BlobConfig `json:"blobSchedule"` | |
| BlobSchedule *params.BlobConfig `json:"blobsSchedule"` |
According to the spec this should be blobsSchedule, I think we should change the spec here though...
| @@ -1135,6 +1135,34 @@ func (api *BlockChainAPI) CreateAccessList(ctx context.Context, args Transaction | |||
| return result, nil | |||
| } | |||
|
|
|||
| type config struct { | |||
There was a problem hiding this comment.
Could we get a testcase for this, there are some tests in the EIP that we could use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will probably be mostly supplanted by #32224, but this should do for now for devnet 3.