cmd, eth/catalyst: exit geth only if exitWhenSynced is specified #32149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
MariusVanDerWijden,
lightclient,
fjl and
jwasinger
as code owners
|
If INFO [07-04|19:53:30.110] Waiting for peers to retrieve sync target
INFO [07-04|19:53:31.283] New local node record seq=1,748,495,301,014 id=0675dea4fd3489a3 ip=122.247.51.135 udp=31666 tcp=31666
INFO [07-04|19:53:40.113] Removing old bloom bits database in progress... elapsed=10.003s
INFO [07-04|19:53:40.310] Block synchronisation started
WARN [07-04|19:53:40.311] Retrieved pivot header from local number=5,163,530 hash=bff7fe..02866c latest=5,163,594 oldest=5,163,594
INFO [07-04|19:53:40.652] Removing old bloom bits database finished elapsed=10.542s
INFO [07-04|19:53:45.310] Full-sync target reached number=5,163,594 hash=b9c677..2a0cb1
INFO [07-04|19:53:45.310] Terminating the node
INFO [07-04|19:53:45.310] HTTP server stopped endpoint=127.0.0.1:4778
INFO [07-04|19:53:45.311] HTTP server stopped endpoint=127.0.0.1:5778
INFO [07-04|19:53:45.311] HTTP server stopped endpoint=127.0.0.1:6666
INFO [07-04|19:53:45.311] IPC endpoint closed url=/home/gary/eth-sepolia-hash/el/geth.ipc
INFO [07-04|19:53:47.485] Ethereum protocol stopped
INFO [07-04|19:53:47.485] Transaction pool stopped
INFO [07-04|19:53:47.551] Blockchain stopped |
|
Whats the idea behind this? Couldn't you just write a script that sends a SIGTERM once the node is synced up, if you want the node to exit when its synced? |
jwasinger
approved these changes
Jul 8, 2025
The issue is we always terminate the Geth when the target is reached, by default. With this PR, the behavior is changed, keeping Geth running unless |
howjmay
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Aug 27, 2025
…ereum#32149) This pull request modifies the behavior of `--synctarget` to terminate the node only when `--exitWhenSynced` is explicitly specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the behavior of
--synctargetto terminate the nodeonly when
--exitWhenSyncedis explicitly specified.