Skip to content

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Mar 12, 2025

Here I am adding a config option and geth flag (--history.chain) for configuring history pruning. There are two options available:

  • --history.chain all is the default and will keep all history like before.
  • --history.chain postmerge will configure the history cutoff point to the merge block.

The option doesn't actually do anything right now, but we need it as a precursor for other history pruning changes.

@MariusVanDerWijden
Copy link
Member

Tests:

> ./build/bin/geth --dev --history.chain asdf console
Fatal: --history.chain: unknown sync mode "asdf", want "all" or "postmerge"
>./build/bin/geth --dev --history.chain all console
[opens js console] 
> ./build/bin/geth --dev --history.chain postmerge console
ERROR[03-13|09:58:05.090] Head block is not reachable
Fatal: Failed to register the Ethereum service: no history pruning point is defined for genesis 65f04ca34fd71d10531e5b2215c05579e099b4c7bcc58d83ea1d0bfab829d08a

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl merged commit 1ca2da8 into ethereum:master Mar 13, 2025
3 of 4 checks passed
@s1na s1na mentioned this pull request Mar 13, 2025
GrapeBaBa pushed a commit to optimism-java/shisui that referenced this pull request Mar 16, 2025
Here I am adding a config option and geth flag (`--history.chain`) for
configuring history pruning. There are two options available:

- `--history.chain all` is the default and will keep all history like
before.
- `--history.chain postmerge` will configure the history cutoff point to
the merge block.

The option doesn't actually do anything right now, but we need it as a
precursor for other history pruning changes.
@rjl493456442 rjl493456442 added this to the 1.15.6 milestone Mar 17, 2025
sivaratrisrinivas pushed a commit to sivaratrisrinivas/go-ethereum that referenced this pull request Apr 21, 2025
Here I am adding a config option and geth flag (`--history.chain`) for
configuring history pruning. There are two options available:

- `--history.chain all` is the default and will keep all history like
before.
- `--history.chain postmerge` will configure the history cutoff point to
the merge block.

The option doesn't actually do anything right now, but we need it as a
precursor for other history pruning changes.
jakub-freebit pushed a commit to fblch/go-ethereum that referenced this pull request Jul 3, 2025
Here I am adding a config option and geth flag (`--history.chain`) for
configuring history pruning. There are two options available:

- `--history.chain all` is the default and will keep all history like
before.
- `--history.chain postmerge` will configure the history cutoff point to
the merge block.

The option doesn't actually do anything right now, but we need it as a
precursor for other history pruning changes.
howjmay pushed a commit to iotaledger/go-ethereum that referenced this pull request Aug 27, 2025
Here I am adding a config option and geth flag (`--history.chain`) for
configuring history pruning. There are two options available:

- `--history.chain all` is the default and will keep all history like
before.
- `--history.chain postmerge` will configure the history cutoff point to
the merge block.

The option doesn't actually do anything right now, but we need it as a
precursor for other history pruning changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants