Skip to content

accounts/abi: Improve unpack performance #31292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

accounts/abi: Improve unpack performance #31292

wants to merge 2 commits into from

Conversation

Exca-DK
Copy link
Contributor

@Exca-DK Exca-DK commented Mar 1, 2025

Reduces alloc by extra loop iteration, slight performance improvement on my local machine

            │   MASTER    │                 PR                 │
            │   sec/op    │   sec/op     vs base               │
Unpack/0-32   217.9n ± 5%   170.3n ± 2%  -21.84% (p=0.002 n=6)
Unpack/1-32   628.7n ± 9%   573.5n ± 7%   -8.78% (p=0.002 n=6)

@MariusVanDerWijden MariusVanDerWijden mentioned this pull request Mar 14, 2025
Merged
@MariusVanDerWijden
Copy link
Member

Sorry that it took so long, I was unable to push to your branch, so I opened a new PR: #31387
I will close this one for now. You will get full attribution once the PR is merged into master, thanks for your contribution!

MariusVanDerWijden added a commit that referenced this pull request Mar 14, 2025
@MariusVanDerWijden @Exca-DK
accounts/abi: improve unpack performance (#31387)
e5758c6 
Slightly improves performance of abi.Unpack

```
Before
BenchmarkUnpack/0-14   5965714       210.9 ns/op     280 B/op       5 allocs/op
BenchmarkUnpack/1-14   2148283       569.7 ns/op     688 B/op      16 allocs/op

After:
BenchmarkUnpack/0-14  	 7693365	       151.2 ns/op	     136 B/op	       4 allocs/op
BenchmarkUnpack/1-14  	 2261294	       508.9 ns/op	     544 B/op	      15 allocs/op
```

replaces #31292 since I was
unable to push to your branch @Exca-DK

---------

Co-authored-by: Exca-DK <[email protected]>
GrapeBaBa pushed a commit to optimism-java/shisui that referenced this pull request Mar 16, 2025
@MariusVanDerWijden @Exca-DK @GrapeBaBa
accounts/abi: improve unpack performance (ethereum#31387)
030b0cb 
Slightly improves performance of abi.Unpack

```
Before
BenchmarkUnpack/0-14   5965714       210.9 ns/op     280 B/op       5 allocs/op
BenchmarkUnpack/1-14   2148283       569.7 ns/op     688 B/op      16 allocs/op

After:
BenchmarkUnpack/0-14  	 7693365	       151.2 ns/op	     136 B/op	       4 allocs/op
BenchmarkUnpack/1-14  	 2261294	       508.9 ns/op	     544 B/op	      15 allocs/op
```

replaces ethereum#31292 since I was
unable to push to your branch @Exca-DK

---------

Co-authored-by: Exca-DK <[email protected]>
rjl493456442 pushed a commit to rjl493456442/go-ethereum that referenced this pull request Mar 17, 2025
@MariusVanDerWijden @Exca-DK @rjl493456442
accounts/abi: improve unpack performance (ethereum#31387)
d3d7ae2 
Slightly improves performance of abi.Unpack

```
Before
BenchmarkUnpack/0-14   5965714       210.9 ns/op     280 B/op       5 allocs/op
BenchmarkUnpack/1-14   2148283       569.7 ns/op     688 B/op      16 allocs/op

After:
BenchmarkUnpack/0-14  	 7693365	       151.2 ns/op	     136 B/op	       4 allocs/op
BenchmarkUnpack/1-14  	 2261294	       508.9 ns/op	     544 B/op	      15 allocs/op
```

replaces ethereum#31292 since I was
unable to push to your branch @Exca-DK

---------

Co-authored-by: Exca-DK <[email protected]>
ucwong pushed a commit to CortexFoundation/CortexTheseus that referenced this pull request Mar 24, 2025
@MariusVanDerWijden @Exca-DK @ucwong
accounts/abi: improve unpack performance (#31387)
f8a2008 
Slightly improves performance of abi.Unpack

```
Before
BenchmarkUnpack/0-14   5965714       210.9 ns/op     280 B/op       5 allocs/op
BenchmarkUnpack/1-14   2148283       569.7 ns/op     688 B/op      16 allocs/op

After:
BenchmarkUnpack/0-14  	 7693365	       151.2 ns/op	     136 B/op	       4 allocs/op
BenchmarkUnpack/1-14  	 2261294	       508.9 ns/op	     544 B/op	      15 allocs/op
```

replaces ethereum/go-ethereum#31292 since I was
unable to push to your branch @Exca-DK

---------

Co-authored-by: Exca-DK <[email protected]>
sivaratrisrinivas pushed a commit to sivaratrisrinivas/go-ethereum that referenced this pull request Apr 21, 2025
@MariusVanDerWijden @Exca-DK @sivaratrisrinivas
accounts/abi: improve unpack performance (ethereum#31387)
b9501cb 
Slightly improves performance of abi.Unpack

```
Before
BenchmarkUnpack/0-14   5965714       210.9 ns/op     280 B/op       5 allocs/op
BenchmarkUnpack/1-14   2148283       569.7 ns/op     688 B/op      16 allocs/op

After:
BenchmarkUnpack/0-14  	 7693365	       151.2 ns/op	     136 B/op	       4 allocs/op
BenchmarkUnpack/1-14  	 2261294	       508.9 ns/op	     544 B/op	      15 allocs/op
```

replaces ethereum#31292 since I was
unable to push to your branch @Exca-DK

---------

Co-authored-by: Exca-DK <[email protected]>
galaio pushed a commit to galaio/bsc that referenced this pull request May 29, 2025
@MariusVanDerWijden @Exca-DK @galaio
accounts/abi: improve unpack performance (#31387)
9700f2f 
Slightly improves performance of abi.Unpack

```
Before
BenchmarkUnpack/0-14   5965714       210.9 ns/op     280 B/op       5 allocs/op
BenchmarkUnpack/1-14   2148283       569.7 ns/op     688 B/op      16 allocs/op

After:
BenchmarkUnpack/0-14  	 7693365	       151.2 ns/op	     136 B/op	       4 allocs/op
BenchmarkUnpack/1-14  	 2261294	       508.9 ns/op	     544 B/op	      15 allocs/op
```

replaces ethereum/go-ethereum#31292 since I was
unable to push to your branch @Exca-DK

---------

Co-authored-by: Exca-DK <[email protected]>
galaio pushed a commit to galaio/bsc that referenced this pull request May 29, 2025
@MariusVanDerWijden @Exca-DK @galaio
accounts/abi: improve unpack performance (#31387)
eef7955 
Slightly improves performance of abi.Unpack

```
Before
BenchmarkUnpack/0-14   5965714       210.9 ns/op     280 B/op       5 allocs/op
BenchmarkUnpack/1-14   2148283       569.7 ns/op     688 B/op      16 allocs/op

After:
BenchmarkUnpack/0-14  	 7693365	       151.2 ns/op	     136 B/op	       4 allocs/op
BenchmarkUnpack/1-14  	 2261294	       508.9 ns/op	     544 B/op	      15 allocs/op
```

replaces ethereum/go-ethereum#31292 since I was
unable to push to your branch @Exca-DK

---------

Co-authored-by: Exca-DK <[email protected]>
jakub-freebit pushed a commit to fblch/go-ethereum that referenced this pull request Jul 3, 2025
@MariusVanDerWijden @Exca-DK @jakub-freebit
accounts/abi: improve unpack performance (ethereum#31387)
3a7ec98 
Slightly improves performance of abi.Unpack

```
Before
BenchmarkUnpack/0-14   5965714       210.9 ns/op     280 B/op       5 allocs/op
BenchmarkUnpack/1-14   2148283       569.7 ns/op     688 B/op      16 allocs/op

After:
BenchmarkUnpack/0-14  	 7693365	       151.2 ns/op	     136 B/op	       4 allocs/op
BenchmarkUnpack/1-14  	 2261294	       508.9 ns/op	     544 B/op	      15 allocs/op
```

replaces ethereum#31292 since I was
unable to push to your branch @Exca-DK

---------

Co-authored-by: Exca-DK <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@MariusVanDerWijden MariusVanDerWijden Awaiting requested review from MariusVanDerWijden MariusVanDerWijden is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Exca-DK @MariusVanDerWijden