rlp/rlpgen: implement package renaming support #31148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did you close this? |
Accidentally. I was making another pull request, so I thought it was already closed. To my happiness I can restore the branch |
This commit adds support for package renaming in the RLP code generator to handle import name conflicts. Key changes include: - Added automatic package alias generation for conflicting imports - Implemented package loading to get correct package names - Modified import handling to support aliased imports - Updated importsList to generate proper import statements with aliases - Added helper functions for alias management The changes allow the code generator to handle cases where multiple imported packages have the same base name by automatically generating unique aliases, improving the robustness of the generated code.
fjl
approved these changes
Aug 1, 2025
howjmay
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Aug 27, 2025
This adds support for importing types from multiple identically-named packages. --------- Co-authored-by: Felix Lange <[email protected]>
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 29, 2025
This adds support for importing types from multiple identically-named packages. --------- Co-authored-by: Felix Lange <[email protected]>
19 tasks
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Aug 31, 2025
This adds support for importing types from multiple identically-named packages. --------- Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: Felix Lange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for package renaming in the RLP code generator to handle import name conflicts. Key changes include:
The changes allow the code generator to handle cases where multiple imported packages have the same base name by automatically generating unique aliases, improving the robustness of the generated code.