eth/catalyst, core/txpool/blobpool: make tests output less logs#30563
Merged
holiman merged 1 commit intoethereum:masterfrom Oct 10, 2024
Merged
eth/catalyst, core/txpool/blobpool: make tests output less logs#30563holiman merged 1 commit intoethereum:masterfrom
holiman merged 1 commit intoethereum:masterfrom
Conversation
holiman
requested review from
gballet,
karalabe,
lightclient and
rjl493456442
as code owners
jwasinger
approved these changes
Oct 9, 2024
MariusVanDerWijden
approved these changes
Oct 10, 2024
Member
MariusVanDerWijden
left a comment
MariusVanDerWijden
left a comment
There was a problem hiding this comment.
Yes thanks, I often find myself scrolling through hundreds of lines just to find out the name of a failing test
holiman
added a commit
that referenced
this pull request
Nov 19, 2024
A couple of tests set the debug level to `TRACE` on stdout, and all subsequent tests in the same package are also affected by that, resulting in outputs of tens of megabytes. This PR removes such calls from two packages where it was prevalent. This makes getting a summary of failing tests simpler, and possibly reduces some strain from the CI pipeline.
jakub-freebit
pushed a commit
to fblch/go-ethereum
that referenced
this pull request
Jul 3, 2025
…reum#30563) A couple of tests set the debug level to `TRACE` on stdout, and all subsequent tests in the same package are also affected by that, resulting in outputs of tens of megabytes. This PR removes such calls from two packages where it was prevalent. This makes getting a summary of failing tests simpler, and possibly reduces some strain from the CI pipeline.
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
…reum#30563) A couple of tests set the debug level to `TRACE` on stdout, and all subsequent tests in the same package are also affected by that, resulting in outputs of tens of megabytes. This PR removes such calls from two packages where it was prevalent. This makes getting a summary of failing tests simpler, and possibly reduces some strain from the CI pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging one failing test in my locals-rewrite, I noticed that the ci-testrunner-output was
18MB.A couple of unrelated tests set the debug level to
TRACEon stdout, and all subsequent tests in the same package would thus also be affected by that.This PR removes such calls from two packages where it was prevalent. This makes getting a summary of failing tests simpler, and possibly reduces some strain from the CI pipeline.