all: implement flat deposit requests encoding#30425
Merged
fjl merged 32 commits intoethereum:masterfrom Oct 9, 2024
Merged
Conversation
fjl
requested review from
MariusVanDerWijden,
gballet,
holiman,
karalabe,
lightclient and
rjl493456442
as code owners
fjl
force-pushed
the
core-flat-deposit-requests
branch
from
b61af3b to
0be1fe8
Compare
lightclient
reviewed
Oct 7, 2024
| if conf.IsPrague(num, g.Timestamp) { | ||
| head.RequestsHash = &types.EmptyRequestsHash | ||
| requests = make(types.Requests, 0) | ||
| emptyRequests := [][]byte{{0}} |
Member
There was a problem hiding this comment.
kinda weird to just have the deposit request prefix just as a bare 0 value here instead of named?
lightclient
reviewed
Oct 7, 2024
lightclient
reviewed
Oct 7, 2024
islishude
reviewed
Oct 8, 2024
islishude
reviewed
Oct 8, 2024
| } | ||
|
|
||
| // CalcRequestsHash creates the block requestsHash value for a list of requests. | ||
| func CalcRequestsHash(requests [][]byte) common.Hash { |
Contributor
There was a problem hiding this comment.
It can be rewrote to following to eliminate memory allocation
func CalcRequestsHash(requests [][]byte) common.Hash {
h1, h2 := sha256.New(), sha256.New()
var buf common.Hash
for _, item := range requests {
h1.Reset()
h1.Write(item)
h2.Write(h1.Sum(buf[:0]))
}
h2.Sum(buf[:0])
return buf
}
Contributor
Author
There was a problem hiding this comment.
This is a very clever suggestion!
islishude
reviewed
Oct 9, 2024
Co-authored-by: Shude Li <islishude@gmail.com>
islishude
reviewed
Oct 9, 2024
| Uncles []*types.Header // Uncles contained within a block | ||
| Withdrawals []*types.Withdrawal `rlp:"optional"` // Withdrawals contained within a block | ||
| Requests []*types.Request `rlp:"optional"` // Requests contained within a block | ||
| Requests [][]byte `rlp:"optional"` // Requests contained within a block |
Contributor
There was a problem hiding this comment.
I just made a PR to remove it
fjl
pushed a commit
that referenced
this pull request
Oct 10, 2024
Block no longer has Requests. This PR just removes some code that wasn't removed in #30425.
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
This implements recent changes to EIP-7685, EIP-6110, and execution-apis. --------- Co-authored-by: lightclient <lightclient@protonmail.com> Co-authored-by: Shude Li <islishude@gmail.com>
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
Block no longer has Requests. This PR just removes some code that wasn't removed in #30425.
jakub-freebit
pushed a commit
to fblch/go-ethereum
that referenced
this pull request
Jul 3, 2025
This implements recent changes to EIP-7685, EIP-6110, and execution-apis. --------- Co-authored-by: lightclient <lightclient@protonmail.com> Co-authored-by: Shude Li <islishude@gmail.com>
jakub-freebit
pushed a commit
to fblch/go-ethereum
that referenced
this pull request
Jul 3, 2025
Block no longer has Requests. This PR just removes some code that wasn't removed in ethereum#30425.
5 tasks
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
This implements recent changes to EIP-7685, EIP-6110, and execution-apis. --------- Co-authored-by: lightclient <lightclient@protonmail.com> Co-authored-by: Shude Li <islishude@gmail.com>
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
Block no longer has Requests. This PR just removes some code that wasn't removed in ethereum#30425.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements changes from
engine: unified list of opaque requests execution-apis#577