Skip to content

pebble: Update pebble to fix mips incompatibility #28378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ajsutton
Copy link
Contributor

Updates pebble to include cockroachdb/pebble#3005 which fixes compilation for 32-bit mips architectures. The dependency meant geth can't currently be built for mips and updating pebble fix that.

From what I can see pebble isn't tagging releases and the previous version used was just an arbitrary hash. Not sure if there's a process you're using to vet which version to pick. The diff between the previous version and this new one is cockroachdb/pebble@aa077af...f6cde3f

@ajsutton
Copy link
Contributor Author

TestAuthEndpoints is failing in CI but passing for me locally (and on the Windows amd build) so I think it's flaky.

The windows 386 build is failing with a compile error in blake2b but its also doing that on other PR builds so I think it may be broken on master.

@holiman
Copy link
Contributor

holiman commented Oct 20, 2023

They don't explicitly tag releases, but they do have release-branches which we try to pick from (or stay close to). See e.g https://github.com/cockroachdb/pebble/tree/crl-release-23.2

That said, would be good to fix the incompatibility...

@ajsutton
Copy link
Contributor Author

Ah, ok that makes sense. My guess is that MIPs isn't a particularly popular platform for geth - I only found this because we use a MIPs VM as part of our fault proofs system and it pulls in op-geth for the EVM and block processing code. For Optimism, we could just override the version of pebble used there to have this fix - it doesn't actually use pebble, we just need it to compile. Then we can just pull in the next pebbledb release once it's out.

@ajsutton
Copy link
Contributor Author

I saw the pebble branch crl-release-23.2 was updated so pulled that in here, but it's actually just cherry-picked a few updates and not the mips fix. So still no actual release with the mips fix.

So pointed back to the commit on master with the pebble fix and will have to keep waiting for a pebble release with the fix. I'm happy to make this draft or close it until that release comes out if it helps you keep things tidy.

@ajsutton
Copy link
Contributor Author

Closing this as I've stopped checking for releases - I figured it will get pulled in at some point and its easy to specify a different version in downstream projects if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants