-
Notifications
You must be signed in to change notification settings - Fork 21.2k
core/vm: optimisations #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
core/vm: optimisations #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also reduces the time required spend in the VM
@@ -31,6 +33,15 @@ type Environment interface { | |||
Create(me ContextRef, data []byte, gas, price, value *big.Int) ([]byte, error, ContextRef) | |||
} | |||
|
|||
type StructLog struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document this.
// StructLogs are emitted by the VM when running contract code.
// ...
type StructLog struct {
d5d8b9c
to
fc2a061
Compare
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this pull request
Jan 20, 2022
### Description This should reduce problems with using data-dirs from full nodes. This will not completely eliminate the problem if a data-dir is reused from a validator. ### Other changes ### Tested Confirmed that full nodes don't create the replica state and that nodes configured with --mine do. ### Related issues ### Backwards compatibility Backwards compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vm.pc
from*big.Int
touint64