Skip to content

Conversation

@LouisTsai-Csie
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie commented Dec 30, 2025

🗒️ Description

This is for the gas repricing analysis effort. Our version 1 benchmark infra only supports the opcode (tests/benchmark/compute/instruction) scenario, and this adds support to the precompiles (tests/benchmark/compute/precompiles). Now we are able to support most of the precompiles, but still a subset of them are failling.

  • Modexp: 54 fails
  • BLS381: 8 fails
  • BN128 12 fails

The issue seems to related to insufficient gas consider the current block gas limit, but more in-depth analysis is required.

Other benchmark tests are running correctly under fill mode, we will later configure the fixed_opcode_count.json configuration for this after PR #1946 done.

Other enhancement:

  • Add missing memory configurations for IDENTITY, SHA256, RIPEMD160 precompiles.
  • Fix broken benchmark by updating gas_benchmark_value to tx_gas_limit to consider eip-7825.

🔗 Related Issues or PRs

None

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.33%. Comparing base (81276a0) to head (4dafaf2).
⚠️ Report is 1 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #1955   +/-   ##
================================================
  Coverage            86.33%   86.33%           
================================================
  Files                  538      538           
  Lines                34557    34557           
  Branches              3222     3222           
================================================
  Hits                 29835    29835           
  Misses                4148     4148           
  Partials               574      574           
Flag Coverage Δ
unittests 86.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LouisTsai-Csie LouisTsai-Csie self-assigned this Dec 30, 2025
@LouisTsai-Csie LouisTsai-Csie added the A-test-benchmark Area: execution_testing.benchmark and tests/benchmark label Dec 30, 2025
@LouisTsai-Csie LouisTsai-Csie changed the title feat: fixed precompile count support fea(test-benchmark)t: fixed precompile count support Dec 30, 2025
@LouisTsai-Csie LouisTsai-Csie marked this pull request as ready for review December 30, 2025 13:49
@LouisTsai-Csie LouisTsai-Csie changed the title fea(test-benchmark)t: fixed precompile count support feat(test-benchmark): fixed precompile count support Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-benchmark Area: execution_testing.benchmark and tests/benchmark

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant