feat(test-benchmark): fixed precompile count support #1955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This is for the gas repricing analysis effort. Our version 1 benchmark infra only supports the opcode (
tests/benchmark/compute/instruction) scenario, and this adds support to the precompiles (tests/benchmark/compute/precompiles). Now we are able to support most of the precompiles, but still a subset of them are failling.The issue seems to related to insufficient gas consider the current block gas limit, but more in-depth analysis is required.
Other benchmark tests are running correctly under fill mode, we will later configure the
fixed_opcode_count.jsonconfiguration for this after PR #1946 done.Other enhancement:
IDENTITY,SHA256,RIPEMD160precompiles.gas_benchmark_valuetotx_gas_limitto consider eip-7825.🔗 Related Issues or PRs
None
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture