Skip to content

Conversation

@nerolation
Copy link
Contributor

πŸ—’οΈ Description

This PR adds three negative test cases that ensure clients reject blocks whose Block Access List contains an out-of-range block_access_index (len(transactions)+2). The suite covers (1) a spurious storage entry whose slot is also legitimately read by another transaction, (2) the same but with a legitimate write, and (3) no other transactions touching the slot. In all variants, the block must be rejected with INVALID_BLOCK_ACCESS_LIST, ensuring strict bounds-checking of BAL indices independent of whether the referenced (address, slot) is otherwise accessed in-block.

πŸ”— Related Issues or PRs

EIP clarification ethereum/EIPs#10990

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 86.25%. Comparing base (2344445) to head (4117531).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           eips/amsterdam/eip-7928    #1953   +/-   ##
========================================================
  Coverage                    86.25%   86.25%           
========================================================
  Files                          538      538           
  Lines                        34561    34561           
  Branches                      3224     3224           
========================================================
  Hits                         29809    29809           
  Misses                        4165     4165           
  Partials                       587      587           
Flag Coverage Ξ”
unittests 86.25% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant