Skip to content

Conversation

@fselmo
Copy link
Contributor

@fselmo fselmo commented Dec 17, 2025

πŸ—’οΈ Description

  • This is a feat / fix as the json infra tests are currently not working since we were not generating the bal hash appropriately. This is likely fixed in the new tests version, so updating this here and putting up a PR to run the CI and double check. We should address any remaining issues in this PR, if any.

πŸ”— Related Issues or PRs

See #1844 for more context

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo added C-feat Category: an improvement or new feature A-spec-tests Area: tests for specifications e.g. json_infra labels Dec 17, 2025
@fselmo fselmo changed the base branch from forks/amsterdam to eips/amsterdam/eip-7928 December 17, 2025 23:21
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (eips/amsterdam/eip-7928@ba0eec1). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             eips/amsterdam/eip-7928    #1939   +/-   ##
==========================================================
  Coverage                           ?   86.25%           
==========================================================
  Files                              ?      538           
  Lines                              ?    34561           
  Branches                           ?     3224           
==========================================================
  Hits                               ?    29809           
  Misses                             ?     4165           
  Partials                           ?      587           
Flag Coverage Ξ”
unittests 86.25% <ΓΈ> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-spec-tests Area: tests for specifications e.g. json_infra C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant