t8n: Return InvalidBlock exception in result.blockException

[marioevz]

What was wrong?

Block-level exceptions, such the ones raised when the system contract calls failed, resulted in t8n returning an empty response instead of parseable JSON.

How was it fixed?

Added a new field in the T8N's response's field result that is called blockException, which is populated in case of an error.

In this PR only an exception in process_general_purpose_requests will be caught and populate the extra field, so every other exception is not caught and will still result in the same behavior, but I think each case should be analyzed separately.

Cute Animal Picture

[SamWilsn]

Should we hoist this up into:

execution-specs/src/ethereum_spec_tools/evm_tools/t8n/__init__.py

Line 202 in 8707c28

def run_blockchain_test(self) -> None:

?

We can wrap the whole function body in a try/except, since per-transaction exceptions are caught here.

[marioevz]

Yes that sounds better. Is run_blockchain_test part of forks/prague? I cannot see it in this version of the file.

[SamWilsn]

I believe so, yeah.

[marioevz]

@SamWilsn I've rebased to forks/prague and applied your suggestion.

Let me know if it's ok.

Just tested and it's not working anymore, I need to take another look.

[marioevz]

@SamWilsn I've rebased to forks/prague, applied your suggestion, fixed my code and now it's working finally.

Let me know if it's ok.

[marioevz]

Just as a sanity check, I did a local check of the fixtures generated with:

• This fix + EOAs that delegate to a precompile #1191 + chore(deps): bump execution-specs to v1.17.0 for fill and unit tests execution-spec-tests#1454
• Only EOAs that delegate to a precompile #1191 + chore(deps): bump execution-specs to v1.17.0 for fill and unit tests execution-spec-tests#1454

And the resulting generated test fixtures were identical.

[gurukamath]

LGTM! The only nit would perhaps be to avoid the huge try-except block in run_blockchain_test. Defining the logic in the try block as a separate function.

PS: Perhaps that was the original implementation.