EELS Update EIP-7623: Apply floor gas cost after refund #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
gurukamath
approved these changes
Jan 10, 2025
chfast
reviewed
Jan 10, 2025
chfast
approved these changes
Jan 10, 2025
|
Lgtm. |
gurukamath
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
EIP-7623 Spec needs update to latest version changed by this PR: ethereum/EIPs#9227
Calldata floor gas cost is now compared to the execution gas cost minus the refund, instead of the refund being applied to the floor data cost in case it was higher than the execution gas cost.
How was it fixed?
I updated the logic and moved some of the variables to make the change easier and more readable. Let me know if this is ok, or rather we should leave the original structure.
I'm writing the EEST tests tomorrow and will run them to verify the changes.
Cute Animal Picture