-
Notifications
You must be signed in to change notification settings - Fork 437
Explore Possibility of Moving ethereum_test_exceptions to EELS #1422
Copy link
Copy link
Open
Labels
staleThe Issue/PR has not had any activity for 60 days. PRs will be automatically closed.The Issue/PR has not had any activity for 60 days. PRs will be automatically closed.
Milestone
Description
Currently we have test exception definitions here: https://github.com/ethereum/execution-specs/tree/forks/osaka/src/ethereum_spec_tests/ethereum_test_exceptions.
These are used in tests as means to verify that the state transition failed in the way the test expects it to.
I suggest we move these to the specs part of the repo to:
- Make them canonical, so the spec definition accounts for all the different ways it can produce an exception.
- Re-use the same exceptions in the tests and avoid having to parse strings/regex matches.
For this to work, the current definitions in ethereum_test_exceptions should subclass Exception so we can raise them directly in EELS.
Open to discussion on how this is a good/bad idea!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
staleThe Issue/PR has not had any activity for 60 days. PRs will be automatically closed.The Issue/PR has not had any activity for 60 days. PRs will be automatically closed.