-
Notifications
You must be signed in to change notification settings - Fork 167
♻️ refactor(eest): Migrate env_init
to eest make env
#996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @raxhvl! It would def be nice to have this cleaned up in the upcoming release.
I had in mind we'd name this make
sub-comand env
, i.e.,
uv run eest make env
as I think we're likely to subsequently add a config
sub-command that helps users create a user-specific config profile for use within EEST.
Were you anticipating having the env.vaml
generation just one step of creating a broader user config profile? Ideas welcome.
Btw, we're suffering from unrelated fails again in the CI - fix in progress.
Thanks for flagging this @danceratopz! I now remember our earlier discussion about the name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @raxhvl, just fixed up a couple of other instances in the docs. Otherwise, looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice addition :)
Just one question - was there a reason to opt for env.yaml
over .env
?
My gut would have said to use .env
instead - and load the env vars directly with loadenv()
etc
env_init
to eest
make configenv_init
to eest make env
9ac7ab8
to
8d6c517
Compare
A |
YAML is preferred over remote_nodes:
- name: mainnet_archive
# Replace with your Ethereum RPC node URL
node_url: http://example.com/
# Optional: Headers for RPC requests
rpc_headers:
client-secret: <secret> |
🗒️ Description
This tiny PR introduces the
eest make config
command. It would be nice to have this included in the upcoming release; I'd rather not have a dangling module in it.🔗 Related Issues
Closes #970
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.