new(tests): EOF - EIP-4750: add fibonacci and factorial tests for CALLF #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
added
scope:tests
pdobacz
approved these changes
Oct 25, 2024
Not this one, #914 finishes the job. |
shemnon
reviewed
Oct 25, 2024
tests/osaka/eip7692_eof_v1/eip4750_functions/test_callf_execution.py
Outdated
Show resolved
Hide resolved
shemnon
reviewed
Oct 25, 2024
tests/osaka/eip7692_eof_v1/eip4750_functions/test_callf_execution.py
Outdated
Show resolved
Hide resolved
marioevz
approved these changes
Oct 25, 2024
tests/osaka/eip7692_eof_v1/eip4750_functions/test_callf_execution.py
Outdated
Show resolved
Hide resolved
chfast
force-pushed
the
eof/callf_fib_factorial
branch
from
6e659a4 to
6cf1f6d
Compare
Add tests implementing fibonacci sequence and factorial using recursive CALLF instructions. They were originally contributed to ethereum/tests by @hugo-dc in ethereum/tests@89c2147. Tests were additionally parametrized.
chfast
force-pushed
the
eof/callf_fib_factorial
branch
from
6cf1f6d to
7286b04
Compare
marioevz
approved these changes
Oct 28, 2024
marioevz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Add tests implementing fibonacci sequance and factorial using recursive CALLF instructions.
They were originally contributed to ethereum/tests by @hugo-dc in ethereum/tests@89c2147.
I'm migrating the tests separately because they are nice examples.
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.