Skip to content

bug(ci): fix deploy docs tags workflow trigger #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Oct 1, 2024

🗒️ Description

Fixes a bug within the Deploy Docs Tags workflow trigger.

For pre-releases such as [email protected], this workflow was triggered deploying and publishing the docs for this tag.

Please see the docs: https://ethereum.github.io/execution-spec-tests/[email protected]/

Our check to trigger this workflow was v* so any pre-release starting with v would always trigger this docs deployment. The past 3 verkle releases did not trigger this as they failed at the docs build step.

Note

Open to changing to always build and deploy the docs for all releases, including pre-releases.

🔗 Related Issues

N/A

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added type:bug Something isn't working scope:ci Scope: Continuous Integration labels Oct 1, 2024
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! LGTM!

@spencer-tb spencer-tb merged commit 802467c into main Oct 1, 2024
5 checks passed
@spencer-tb spencer-tb deleted the ci-docs-tags-fix branch October 1, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants