Skip to content

feat: block witness checks and test fixes #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

spencer-tb
Copy link
Contributor

🗒️ Description

Adds verkle block witness checks and test fixes.

spencer-tb and others added 30 commits September 5, 2024 17:11
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
verkle: add eip-7709 test
@spencer-tb spencer-tb merged commit fb681a3 into ethereum:verkle/main Oct 1, 2024
1 of 4 checks passed
spencer-tb added a commit to spencer-tb/execution-spec-tests that referenced this pull request Oct 1, 2024
* basic witness checks

* feat(fw): add verkle chunkify code helper.

* feat(fw): add all verkle sub commands.

* chore: add chunkify code to init.

* chore: remove witness.

* chore: remove old witness check.

* feat(fw): add witness checks init api.

* chore: fix filling tmp.

* refactor(fw|evm): use WitnessCheck as temp data struct pre-filling.

* chore(fw|evm): fix witness check during fill.

* feat(fw): verify witness function.

* tests: witness check test_balance.

* tests: update witness check test_blockhash_instruction.

* tests: update witness check for remaining tests.

* chore: rename basic mpt to vkt test as transition.

* tests: temp fix test_contract_execution.

* chore: fix format witness check function.

* feat: add basic data values big-endian encoding.

* chore: improve and fix error messages.

* chore: more improvements to error messages.

* chore: fix code hash for witness check.

* chore: more improvements to error messages 2.

* chore: more improvements to error messages 3.

* chore: temp test fix.

* chore: skip blockhash storage slot check temp.

* chore: fix eip4762 test calls.

* tests: small changes.

* verkle: fix test

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: test fix

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fix selfdestruct tests

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fix sstore

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fix extcodesize test

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fix extcodehash tests

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: contract execution fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: many contract execution fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fix more tests bugs

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fix create tests

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: add create with insufficient balance value-bearing

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: create with big calldata fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fix sload test

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: uncomment contract execution subtests

Signed-off-by: Ignacio Hagopian <[email protected]>

* chore: typing bytes fix.

* verkle: more fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: enable all code execution tests

Signed-off-by: Ignacio Hagopian <[email protected]>

* feat: make witness checks exhaustive.

* fix: bug in code chunk.

* feat: test_balance exhaustive checks example.

* temp-fix: check hist. storage cont.

* compilation fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* more fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: call warm fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* simplify

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: codecopy/extcodecopy fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: remove noisy comments

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fix coinbase assertions

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fix creates tests

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: extcodesize fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: selfdestruct fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fix sload

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: sstore fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: fix transfer

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: more calls fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: more fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: more fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: more fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* disable temporarily 7709 tests

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: reenable sub-test

* verkle: enable sub-tests with partial witness charging

* verkle: reenable call subtests

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: add eip-7709 test

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: 7709 fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: update 7709 blockhash values

Signed-off-by: Ignacio Hagopian <[email protected]>

* fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* fixes

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: add codecopy test with size bigger than contract

Signed-off-by: Ignacio Hagopian <[email protected]>

* verkle: add system contract execution test via CALL

Signed-off-by: Ignacio Hagopian <[email protected]>

---------

Signed-off-by: Ignacio Hagopian <[email protected]>
Co-authored-by: Ignacio Hagopian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants