fix(fixtures): Fix index generation for EOF tests #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to fix #724 for me, ty! |
spencer-tb
approved these changes
Aug 5, 2024
spencer-tb
pushed a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Aug 8, 2024
* fix(exceptions): Exception string parsing * fix(types): EOF `ContainerKind` parsing * feat(fixtures): Add EOF fixture tests * fix(fixtures): EOF index generation * changelog * fix(exceptions): type check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Fixture filling was failing due to the index generation not supporting parsing EOF tests.
Fixed:
ContainerKindnot parsing correctly on readEOFExceptionparsing due to not being supported byfrom_pipe_strfunctionExceptionBaseand subclasses string parsing🔗 Related Issues
Closes #724
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.