Skip to content

new(tests): EIP-5656/7692 - use new marker to EOF-ize MCOPY test #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Aug 1, 2024

This has some rough edges and is a big rework, but I wanted to see how far along I can get this. In a nutshell this reworks the MCOPY memory expansion test to not require the CALL/GAS combination (relies on the tx gas cost instead, which is understandably uglier).

The upside is that (I think) it works and generates the MCOPY mem expansion tests in the EOF world.

Feedback and thoughts welcome

@marioevz marioevz force-pushed the evm-code-type-marker branch from a87bb09 to 9ef68a4 Compare August 1, 2024 16:47
@pdobacz pdobacz force-pushed the eofize-mcopy-mem-expansion branch from d1cebb8 to d9cdc85 Compare August 1, 2024 16:59
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it works surprisingly good if you take into account that gas introspection is being removed.

We can merge once #610 is merged.

@pdobacz pdobacz force-pushed the eofize-mcopy-mem-expansion branch from d9cdc85 to 31d83c6 Compare August 2, 2024 16:31
@pdobacz pdobacz force-pushed the eofize-mcopy-mem-expansion branch from 31d83c6 to c115011 Compare August 5, 2024 12:29
@marioevz marioevz deleted the branch ethereum:evm-code-type-marker August 8, 2024 22:17
@marioevz marioevz closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants