Skip to content

bug(tests): fix typos in selfdestruct test #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2024
Merged

bug(tests): fix typos in selfdestruct test #608

merged 2 commits into from
Jun 10, 2024

Conversation

winsvega
Copy link
Contributor

@winsvega winsvega commented Jun 7, 2024 •
edited by spencer-tb
Loading

🗒️ Description

Fix typo found by Spencer in selfdestruct test that affected verkle experiments

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega winsvega added the scope:pytest Scope: Changes EEST's pytest plugins label Jun 7, 2024
@winsvega winsvega requested a review from marioevz June 7, 2024 10:19
@marioevz marioevz requested a review from spencer-tb June 7, 2024 15:51
spencer-tb
spencer-tb approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spencer-tb spencer-tb added type:bug Something isn't working scope:tests Scope: Changes EL client test cases in `./tests` labels Jun 10, 2024
@spencer-tb spencer-tb changed the title fix typo in selfdestruct test bug(tests): fix typos in selfdestruct test Jun 10, 2024
@spencer-tb spencer-tb merged commit 5c590c6 into main Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

@marioevz marioevz Awaiting requested review from marioevz

Assignees
No one assigned
Labels
scope:pytest Scope: Changes EEST's pytest plugins scope:tests Scope: Changes EL client test cases in `./tests` type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winsvega @spencer-tb