Skip to content

chore(forks): generate fixtures with the Paris network name #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2024

Conversation

raxhvl
Copy link
Member

@raxhvl raxhvl commented Mar 17, 2024

πŸ—’οΈ Description

closes #469

πŸ”— Related Issues

#469

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Changelog NOT updated because of the trivial nature.

@spencer-tb spencer-tb added scope:forks Scope: Changes ethereum_test_forks package type:chore Type: Chore labels Mar 22, 2024
@spencer-tb spencer-tb changed the title 🧹 Merge -> Paris chore(forks): generate fixtures with the Paris network name Mar 22, 2024
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Raxhvl, this is an addition I'd personally love - but it requires that client teams make this change on their end when consuming the test fixture.

Currently geth responds with:

unsupported fork "Paris"

when running:

evm blocktest

against the appropriate json test fixture containing the test with the "Paris" network name.

I haven't checked but this is likely a very easy change for them! I can have a look :)

Co-authored-by: spencer <[email protected]>
@raxhvl
Copy link
Member Author

raxhvl commented Mar 22, 2024

Sweet. I guess we wait for them then.

@spencer-tb
Copy link
Contributor

Okay so its an quick change on Geth: ethereum/go-ethereum@master...spencer-tb:go-ethereum:tests/init

I want to make sure the tests work when running them on a fully instantiated client in hive:
https://github.com/ethereum/hive/tree/master/simulators/ethereum/pyspec

Assuming the latter, I'd say merging this in is good to go. Ideally we have some PRs ready for each client before our next release.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marioevz marioevz merged commit 392c7fe into ethereum:main Apr 1, 2024
@raxhvl raxhvl deleted the refactor/rename-merge-to-paris branch April 2, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:forks Scope: Changes ethereum_test_forks package type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate tests with Paris keyword instead of Merge
3 participants