Skip to content

fix(tests): Remove beacon root contract from state tests #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Feb 21, 2024

🗒️ Description

Removes the beacon root contract and its execution outcome from the state tests by separating the fork pre-alloc by blockchain and non-blockchain tests.

Also converts the beacon root contract tests to blockchain tests.

🔗 Related Issues

#446

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore scope:fw Scope: Framework (evm|tools|forks|pytest) labels Feb 21, 2024
@marioevz marioevz requested a review from winsvega February 21, 2024 19:15
@winsvega
Copy link
Contributor

let me check

@winsvega
Copy link
Contributor

winsvega commented Feb 22, 2024

it still puts beacon contract in blockchain tests that are automatically filled for cancun (those that do unrelated stuff to beacon root)

@marioevz
Copy link
Member Author

it still puts beacon contract in blockchain tests that are automatically filled for cancun (those that do unrelated stuff to beacon root)

For the blockchain tests it should be fine right? It was the state tests where the issue was.

@marioevz marioevz marked this pull request as ready for review February 22, 2024 13:56
@marioevz marioevz changed the title Remove beacon root contract from state tests fix(tests): Remove beacon root contract from state tests Feb 22, 2024
@winsvega
Copy link
Contributor

so a state test in bc form will still have it inserted into pre?

@marioevz marioevz merged commit 06ed07f into ethereum:main Mar 4, 2024
@marioevz marioevz deleted the remove-beacon-root-contract-from-state-tests branch March 4, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants