Skip to content

github: Remove hive fixtures filling #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jan 8, 2024

πŸ—’οΈ Description

Removes packaging creation of hive fixtures from the github workflows, since they are all now created at the same time but on different folders.

πŸ”— Related Issues

None

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added the type:chore Type: Chore label Jan 8, 2024
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Bye bye hive fixture releases πŸ‘‹

@marioevz
Copy link
Member Author

marioevz commented Jan 8, 2024

I'm creating another PR on top of feat/statetest to include info about the fixtures in the documentation.

So I will merge this now.

@marioevz marioevz merged commit 9610355 into ethereum:feat/statetest Jan 8, 2024
@marioevz marioevz deleted the fix-github-workflows-for-statetests branch January 8, 2024 17:16
marioevz added a commit that referenced this pull request Jan 10, 2024
marioevz added a commit that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants