Skip to content

Conversation

danceratopz
Copy link
Member

🗒️ Description

WIP Keeping as draft until ethereum/hive-python-api#11 is finalized and a non-alpha/non-beta release has been published on pypi.

Replaces the git+https://github.com/marioevz/hive.py version specifier with the freshly published ethereum-hive package.

🔗 Related Issues or PRs

Closes #1560

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md. skipped
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@danceratopz danceratopz added type:chore Type: Chore scope:deps Scope: Updates package dependencies labels Jul 9, 2025
@danceratopz danceratopz changed the title chore(deps): use ethereum-hive package in favor of git+hive.py chore(deps): use ethereum-hive package instead of git+hive.py Jul 9, 2025
@danceratopz danceratopz changed the title chore(deps): use ethereum-hive package instead of git+hive.py chore(deps): use the ethereum-hive package instead of git+hive.py Jul 9, 2025
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approve from me! Looks good! :D

@danceratopz danceratopz marked this pull request as ready for review July 10, 2025 14:08
@marioevz marioevz merged commit 5878612 into main Jul 10, 2025
13 checks passed
@marioevz marioevz deleted the chore/deps-use-ethereum-hive-package branch July 10, 2025 14:09
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I think we should remove the .egg-info from the releases. It looks like it's in the .gitignore already so may need a git rm --cached to reset it?

@danceratopz
Copy link
Member Author

lgtm! I think we should remove the .egg-info from the releases. It looks like it's in the .gitignore already so may need a remove --cached to reset it?

Thanks for checking the release @fselmo! We're going to move the repo under ethereum/ before merging ethereum/hive-python-api#11 I've added a todo to that pr to take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:deps Scope: Updates package dependencies type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(packaging): publish hive.py as a package
4 participants