feat(fill): add --generate-all-formats to enable generation of BlockhainEngineXFixture with other formats
#1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… generation Add new --generate-all-formats command line option that enables generation of all fixture formats including BlockchainEngineXFixture in a single command execution. Key changes: - Add --generate-all-formats CLI option with two-phase execution support. - Phase 1: Generate pre-allocation groups (same as --generate-pre-alloc-groups). - Phase 2: Generate ALL supported fixture formats (vs only BlockchainEngineXFixture). - Update FixtureOutput class to handle new generate_all_formats parameter. - Preserve --generate-all-formats flag in phase 2 execution for proper format selection. - Maintain backward compatibility with existing --generate-pre-alloc-groups workflow. This makes BlockchainEngineXFixture a first-class citizen alongside other fixture formats, enabling comprehensive test coverage generation in a single command while leveraging the performance optimizations of pre-allocation groups.
- Extract _should_use_two_phase_execution() method to simplify complex conditional logic. - Extract _ensure_generate_all_formats_for_tarball() method for cleaner argument processing. - Update create_executions() to use the new helper methods.
- Add should_auto_enable_all_formats property to clarify auto-enable logic. - Improve variable naming: should_generate_all_formats instead of generate_all_formats. - Fix duplication: use existing is_tarball property logic instead of creating duplicate method. - Update tests to use new field name.
…hase enum - Add ExecutionPhase enum with 4 distinct phases: NORMAL, PHASE_1_PREALLOC, PHASE_2_ENGINE_X_ONLY, PHASE_2_ALL_FORMATS. - Extract _determine_execution_phase() method to encapsulate phase logic. - Extract _is_blockchain_engine_x_fixture() helper for format checking. - Extract _determine_fixture_formats() method to handle all 4 execution phases. - Simplify pytest_generate_tests() from 40+ lines of nested conditionals to 2 clean lines.
danceratopz
commented
Jul 7, 2025
There was a problem hiding this comment.
@marioevz had another thought below on this change. Let me know what you think if you agree, I can make the changes in this PR or close this PR and make a new one. Perhaps it's good enough as an intermediate step.
marioevz
force-pushed
the
feat/fill-enable-all-formats
branch
from
26aa033 to
efafc00
Compare
marioevz
force-pushed
the
feat/fill-enable-all-formats
branch
from
a1818da to
26aa033
Compare
marioevz
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
TLDR: This change will generate all fixture fixture formats for both benchmark and normal releases.
The plugin gets 4 modes of operation:
execution-spec-tests/src/pytest_plugins/filler/filler.py
Lines 988 to 994 in 26aa033
NORMAL- this maintains previous behavior w/o--generate-all-formatsflag.Otherwise, this PR:
--generate-all-formatsflag to enableBlockchainEngineXFixturegeneration alongside other fixture formats.--generate-all-formatswhen--outputspecifies a.tar.gzfile.I don't think, we need to change anything under
.github/, as all formats are generated by default if output is a tarball.Usage
Both approaches perform two-phase execution to generate all supported fixture formats.
🔗 Related Issues or PRs
Follow-up to:
BlockchainEngineReorgFixture#1706Fixes #1778
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.