Skip to content

fix(tests): change INVALID_DEPOSIT_EVENT_LAYOUT to BlockException #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

gurukamath
Copy link
Collaborator

🗒️ Description

Some of the tests in tests/prague/eip6110_deposits/test_modified_contract.py fail to parse the deposit logs corresponding to a transaction and expect the transaction to be marked as rejected. However, the parsing of the logs happen outside of the transaction. So the transaction itself is not rejected rather, the block is invalid. We should expect an Invalid Block here in place of a invalid transaction

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests/tests/static have been assigned @ported_from marker.
  • Tests: A PR with removal of converted JSON/YML blockchain tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danceratopz danceratopz added type:bug Something isn't working scope:types Scope: Changes to ethereum_test_types, ethereum_test_base_types labels Jun 19, 2025
@danceratopz danceratopz changed the title fix(tests): Change INVALID_DEPOSIT_EVENT_LAYOUT to BlockException fix(tests): change INVALID_DEPOSIT_EVENT_LAYOUT to BlockException Jun 19, 2025
@marioevz marioevz merged commit 0c33fa0 into ethereum:main Jun 19, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:types Scope: Changes to ethereum_test_types, ethereum_test_base_types type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants