Skip to content

feat(tests): add CLZ opcode EIP-7939) tests #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

feat(tests): add CLZ opcode EIP-7939) tests #1733

merged 1 commit into from
Jun 18, 2025

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Jun 10, 2025

πŸ—’οΈ Description

Adds tests for CLZ (EIP-7939).

πŸ”— Related Issues

N/A

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@jochem-brouwer jochem-brouwer force-pushed the clz-tests branch 3 times, most recently from e7b9c3e to ac3c93e Compare June 10, 2025 11:04
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a start on this! I know you are not finished yet but added some quick comments.

Could we also rename tests/osaka/eip7939_cls to tests/osaka/eip7939_count_leading_zeros and test_clz.py to test_count_leading_zeros.py.
Sorry for being pedantic :D

@spencer-tb spencer-tb added scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature fork:osaka Osaka hardfork labels Jun 11, 2025
@spencer-tb spencer-tb marked this pull request as ready for review June 11, 2025 12:43
@spencer-tb spencer-tb changed the title feat(tests): add CLZ (EIP 7939) tests feat(tests): add CLZ opcode EIP-7939) tests Jun 18, 2025
Co-authored-by: spencer-tb <[email protected]>
Co-authored-by: Mario Vega <[email protected]>
@spencer-tb spencer-tb merged commit f66e4c0 into main Jun 18, 2025
27 checks passed
@spencer-tb spencer-tb deleted the clz-tests branch June 18, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants