-
Notifications
You must be signed in to change notification settings - Fork 167
feat(tests): EIP-7918 - Blob base fee bounded by execution cost #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review and some early comments on this.
Thanks for putting this together!
I think if this fills correctly with |
976a0e0
to
f007046
Compare
42c34d3
to
fb5d79d
Compare
fb5d79d
to
1a3ddea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I added a comment to potentially solve the issue of the intermediate block, we can discuss it and open an issue to address this in a follow up PR.
🗒️ Description
Adds intial tests for EIP-7918, including changes that allow us to use existing EIP-4844 test cases for EIP-7918. Additional tests should be added in the future missing gaps using the EIP checklist.
To trigger EIP-7918 coverage we need to make
reserve_price > 1
by makingbase_fee_per_gas > 16
. This is achieved in within some EIP-4844 tests by adding the following parameterization:@pytest.mark.parametrize("base_fee_per_gas", [7, 100])
Note this parameterization can and should be added to more EIP-4844 tests in the future. I omitted some additions to not have to update the complicated gas calculation logic for now.
🔗 Related Issues
N/A
✅ Checklist