refactor(cli,pytest): improve the cli click interfaces for EEST pytest-based commands
#1654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
added
type:refactor
danceratopz
changed the title
click interfaces for EEST pytest-based commands
spencer-tb
reviewed
May 27, 2025
spencer-tb
approved these changes
May 27, 2025
marioevz
approved these changes
May 27, 2025
Refactored the pytest-based CLI commands (`fill`, `consume`, `execute`) with a modular architecture that eliminates code duplication and enables future multi-phase execution: - Created `PytestCommand` base class and `ArgumentProcessor` abstraction - Added `common_pytest_options` decorator to reduce Click option duplication - Used `functools.wraps` to properly preserve function metadata in decorators - Moved argument processing logic into reusable processor classes - Added verbose logging to show actual pytest commands being executed - Maintained full backward compatibility of user-facing CLI interface - Prepared structure for future two-phase fill execution
…ary cli help logic
danceratopz
force-pushed
the
refactor/pytest-cli-interfaces
branch
from
6979e84 to
f2c7dd8
Compare
|
Weirdly github let me squash merge before this last queued check had ran without bypassing merge rules, so i thought it was a UI glitch. But the lint workflow failed: it's not a lint fail though, here's the error message: "The hosted runner: GitHub Actions 42 lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error." All workflows passed on the squash commit to main. |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Refactored CLI wrappers for pytest-based tools (fill, execute, consume) to create a modular, extensible architecture and eliminated the REQUIRED_FLAGS code smell that required dummy parameters for help commands.
The motivation for this refactor is to make the
fillCLI more extensible, ready for the two-stage fill execution to enable the "shared-alloc" generation.🔗 Related Issues
None.
✅ Checklist