Skip to content

refactor(tests): use the pre fixture in SELFDESTRUCT collision tests #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2025

Conversation

danceratopz
Copy link
Member

πŸ—’οΈ Description

This PR refactors the SELFDESTRUCT collision tests that used hard-coded addresses to instead use the pre fixture from the pre_alloc plugin.

Diffed the traces and evm execution is identical, interestingly:

  1. Call data size changed: e.g. from 0x23 to 0x35 (line 3) - because now the initcode contains full 20 byte addresses instead of hard-coded addresses that occupy less bytes.
  2. Gas values are slightly different: due to different initial allocations.

πŸ”— Related Issues

None

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@danceratopz danceratopz added scope:tests Scope: Changes EL client test cases in `./tests` type:refactor Type: Refactor labels May 22, 2025
@danceratopz danceratopz merged commit 020f728 into main May 26, 2025
26 checks passed
@danceratopz danceratopz deleted the refactor/selfdestruct-tests-to-pre-alloc branch May 26, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:refactor Type: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants