Skip to content

fix(fill): fix --collect-only after introducing FixtureOutput class #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented May 16, 2025

🗒️ Description

Follow-up bug fix to:

Adds a CliRunner-based module test to catch the bug, which is fixed by creating the FixtureOutput object before exiting early if running with --collect-only.

🔗 Related Issues

Introduced in:

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.

@danceratopz danceratopz added the scope:fill Scope: fill command label May 16, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the unit test :)

@marioevz marioevz merged commit 9c95339 into main May 16, 2025
20 checks passed
@marioevz marioevz deleted the fix/fill-collect-only branch May 16, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fill Scope: fill command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants