Skip to content

chore(tests): add conftests to zkevm & bls subdirs to apply zkevm marker #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

chore(tests): add conftests to zkevm & bls subdirs to apply zkevm marker #1534

merged 2 commits into from
May 5, 2025

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented May 5, 2025 •
edited
Loading

🗒️ Description

Automatically apply the zkevm marker to all tests under ./tests/zkevm/ and ./tests/prague/eip2537_bls_12_381_precompiles/ via conftest configuration.

Test via:

fill -m zkevm --from Cancun --until Prague --collect-only -q > zkevm.txt

zkevm.txt

🔗 Related Issues

Fixes

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.

@danceratopz danceratopz added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore feature:zkevm labels May 5, 2025
@danceratopz danceratopz mentioned this pull request May 5, 2025
Closed
kevaundray
kevaundray approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

marioevz
marioevz approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tried using pytestmark inside of the conftest only to find out it's not supported 😢

@marioevz marioevz merged commit 2201c2e into main May 5, 2025
22 checks passed
@marioevz marioevz deleted the apply-zkevm-marker-to-all-bls-tests branch May 5, 2025 18:01
@danceratopz
Copy link
Member Author

LGTM. I tried using pytestmark inside of the conftest only to find out it's not supported 😢

This caught me out too! It seemed such a logical way to do it.

@danceratopz danceratopz mentioned this pull request May 6, 2025
Merged
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
@danceratopz @felix314159
chore(tests): add conftests to zkevm & bls subdirs to apply zkevm mar…
96f97d3 
…ker (ethereum#1534)

* chore(tests): add conftests to zkevm & bls subdirs to apply zkevm marker

* docs: update changelog
@jsign jsign mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
feature:zkevm scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danceratopz @marioevz @kevaundray