fix(tests,fw): Remove EIP-7698 EOF creation txs #1451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marioevz Not 100% sure the solutions around the state/bc tests generators are elegant, but I think this is ok to review now. Fills successfully with |
marioevz
reviewed
Apr 17, 2025
tests/osaka/eip7692_eof_v1/eip7873_tx_create/test_creation_tx.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7692_eof_v1/eip7873_tx_create/test_txcreate_failures.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7692_eof_v1/eip7873_tx_create/test_txcreate_failures.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7692_eof_v1/eip7873_tx_create/test_txcreate_failures.py
Outdated
Show resolved
Hide resolved
marioevz
approved these changes
Apr 17, 2025
Merged
8 tasks
pacrob
pushed a commit
to pacrob/execution-spec-tests
that referenced
this pull request
May 5, 2025
* fix(tests): Remove/Move EIP-7698 tests * fix(fw): add EOF_CREATION_TRANSACTION exception * fix(tests): EIP-7069 to not use EOF creation tx * fix(fw): eof_state_test not to use EOF creation tx * fix(fw): ...test_from_eof_test not to use EOF creation tx * fix(docs): misc remove mentions of EOF creation tx * fix(tests): allow variants of validation exceptions * review comments * Mark `test_legacy_create_tx_eof_initcode` with `xfail` * changelog --------- Co-authored-by: Mario Vega <[email protected]>
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
* fix(tests): Remove/Move EIP-7698 tests * fix(fw): add EOF_CREATION_TRANSACTION exception * fix(tests): EIP-7069 to not use EOF creation tx * fix(fw): eof_state_test not to use EOF creation tx * fix(fw): ...test_from_eof_test not to use EOF creation tx * fix(docs): misc remove mentions of EOF creation tx * fix(tests): allow variants of validation exceptions * review comments * Mark `test_legacy_create_tx_eof_initcode` with `xfail` * changelog --------- Co-authored-by: Mario Vega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Draft removal of EIP-7698. Some interesting test cases in EIP-7698 were recreated in other categories
🔗 Related Issues
NA
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.