Skip to content

feat(execute): Use test spec names as markers for execute #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Mar 28, 2025

🗒️ Description

Adds labeled markers and names to all execute formats, derived from the test spec type names of the test where they came from.

Since we only have a single execute format that matches all specs we have, all execute test names contain "transaction_post" in the ID, and no reference or marker to the specification that was used to fill it:

test_set_code_from_account_with_non_delegating_code[fork_Prague-transaction_post-self_sponsored_True-EMPTY_ACCOUNT]

With this change the test IDs now contain the name of the test spec that was used to produce the test:

test_set_code_from_account_with_non_delegating_code[fork_Prague-state_test-self_sponsored_True-EMPTY_ACCOUNT]

Also we can now narrow execution to a specific type of test using markers.

E.g.

uv run execute hive --fork=Prague -m transaction_test

will run only transaction tests.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:feat type: Feature scope:execute Scope: Changes to the execute command labels Mar 28, 2025
@marioevz marioevz requested a review from danceratopz March 28, 2025 23:44
@marioevz marioevz changed the title fix(specs): Use labeled execute formats always feat(execute): Use test spec names as markers for execute Mar 28, 2025
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/approve!

@marioevz marioevz merged commit 7af6c71 into main Apr 1, 2025
21 checks passed
@marioevz marioevz deleted the execute-markers-and-names branch April 1, 2025 12:57
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
…#1367)

* fix(specs): Use labeled execute formats always

* docs: Changelog

* Update docs/CHANGELOG.md

---------

Co-authored-by: danceratopz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:execute Scope: Changes to the execute command type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants