-
Notifications
You must be signed in to change notification settings - Fork 167
chore: update hive ruleset and add osaka #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Feel free to try run consume for Cancun/Prague/Osaka when reviewing! ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition! Just one comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just one suggestion that could be applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more changes :)
4ab03b6
to
7a89fba
Compare
Co-authored-by: Mario Vega <[email protected]>
7a89fba
to
0d15754
Compare
I decided to remove the recursion as it wasn't necessary for such a simple function! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
) * chore: update hive ruleset and add osaka. Co-authored-by: Mario Vega <[email protected]> * chore: mYpY :P. --------- Co-authored-by: Mario Vega <[email protected]>
🗒️ Description
Primarily adds Osaka to the hive ruleset file. Additional refactoring includes a blob schedule function to prevent things getting messy (a quick addition while adding Osaka).
Before
Previously, you had to manually write out blob schedule keys like this:
After
Now, you can simply write:
🔗 Related Issues
N/A
✅ Checklist