Skip to content

chore: update hive ruleset and add osaka #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

chore: update hive ruleset and add osaka #1355

merged 2 commits into from
Mar 31, 2025

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Mar 26, 2025

🗒️ Description

Primarily adds Osaka to the hive ruleset file. Additional refactoring includes a blob schedule function to prevent things getting messy (a quick addition while adding Osaka).

Before

Previously, you had to manually write out blob schedule keys like this:

    "Prague": {
        "HIVE_FORK_HOMESTEAD": 0,
        ...
        "HIVE_CANCUN_TIMESTAMP": 0,
        "HIVE_CANCUN_BLOB_TARGET": 3,
        "HIVE_CANCUN_BLOB_MAX": 6,
        "HIVE_CANCUN_BLOB_BASE_FEE_UPDATE_FRACTION": 3338477,
        "HIVE_PRAGUE_TIMESTAMP": 0,
        "HIVE_PRAGUE_BLOB_TARGET": 6,
        "HIVE_PRAGUE_BLOB_MAX": 9,
        "HIVE_PRAGUE_BLOB_BASE_FEE_UPDATE_FRACTION": 5007716,
    },

After

Now, you can simply write:

    "Prague": {
        "HIVE_FORK_HOMESTEAD": 0,
        ...
        "HIVE_CANCUN_TIMESTAMP": 0,
        "HIVE_PRAGUE_TIMESTAMP": 0,
        **get_blob_schedule_entries(Prague),
    },

🔗 Related Issues

N/A

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added type:chore Type: Chore scope:consume Scope: Consume command suite fork:osaka Osaka hardfork labels Mar 26, 2025
@spencer-tb
Copy link
Contributor Author

Feel free to try run consume for Cancun/Prague/Osaka when reviewing! ;)

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Just one comment.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one suggestion that could be applied.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more changes :)

@spencer-tb spencer-tb force-pushed the chore-osaka-ruleset branch from 4ab03b6 to 7a89fba Compare March 28, 2025 18:40
@spencer-tb spencer-tb force-pushed the chore-osaka-ruleset branch from 7a89fba to 0d15754 Compare March 30, 2025 10:40
@spencer-tb
Copy link
Contributor Author

I decided to remove the recursion as it wasn't necessary for such a simple function!

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 4870360 into main Mar 31, 2025
21 checks passed
@marioevz marioevz deleted the chore-osaka-ruleset branch March 31, 2025 15:58
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
)

* chore: update hive ruleset and add osaka.

Co-authored-by: Mario Vega <[email protected]>

* chore: mYpY :P.

---------

Co-authored-by: Mario Vega <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:osaka Osaka hardfork scope:consume Scope: Consume command suite type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants