fix(consume): fix loading of multi-index, mixed tx type fixtures #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test fixtures from ethereum/{tests,legacyTests} can be parametrized by data, gas and value index. In this case, the tx type can be either be an access list type transaction (`0x1`), or not (`0x0`). For the latter, the entry in the transaction `accessList` field is set to `null` (an empty list can also be specified, but then this is a `0x1` type tx). This change handles this case.
danceratopz
added
type:bug
marioevz
approved these changes
Mar 19, 2025
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
…ereum#1330) * fix(consume): fix loading of multi-index mixed tx type fixtures Test fixtures from ethereum/{tests,legacyTests} can be parametrized by data, gas and value index. In this case, the tx type can be either be an access list type transaction (`0x1`), or not (`0x0`). For the latter, the entry in the transaction `accessList` field is set to `null` (an empty list can also be specified, but then this is a `0x1` type tx). This change handles this case. * docs: update changelog * docs: update pr link in changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
State test fixtures from
ethereum/{tests,legacyTests}can be parametrized via multiple transactions that take different values ofdata,gasandvalue. In this case, the tx type can be either be an access list type transaction (0x1), or not (0x0). For the latter, the entry in the transactionaccessListfield is set tonull. This change handles this case. An empty list can also be specified as entry in this field, but then this is a0x1type tx.Here's an example:
https://github.com/ethereum/tests/blob/f4f76dc8a0bd99297c70e8a21b1e31ce4263d720/GeneralStateTests/stEIP1559/lowGasPriceOldTypes.json#L170-L173
🔗 Related Issues
None
✅ Checklist