chore(fill): fix --fork/from/until for transition forks
#1311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
added
scope:forks
spencer-tb
force-pushed
the
chore-fix-transition-fork-fill
branch
from
5f11979 to
20e1b14
Compare
danceratopz
reviewed
Mar 14, 2025
4 tasks
danceratopz
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
Very cool thanks! Appreciate the unit test. I/we need to start building these tests out for consume, too!
These collect an identical test set now (as expected):
fill --from Cancun --until Prague --collect-only -q
fill --from ShanghaiToCancunAtTime15k --until Prague --collect-only -q
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Transition forks do not work within
--fork/from/untilwhen usingfill. This PR fixes the latter.>> uv run fill --fork ShanghaiToCancunAtTime15k Error: Unsupported fork provided to --fork: ShanghaiToCancunAtTime15k Available forks: Byzantium, Prague, Homestead, Istanbul, Cancun, Frontier, London, Osaka, Paris, CancunEIP7692, Shanghai, ConstantinopleFix, Berlin, Constantinople Available transition forks: BerlinToLondonAt5, CancunToPragueAtTime15k, ShanghaiToCancunAtTime15k, ParisToShanghaiAtTime15k Exit: Invalid command-line options.🔗 Related Issues
More context: #1307
✅ Checklist