Skip to content

chore(deps): Bump EELS dependency #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 13, 2025
Merged

chore(deps): Bump EELS dependency #1310

merged 5 commits into from
Mar 13, 2025

Conversation

petertdavies
Copy link
Contributor

@petertdavies petertdavies commented Mar 13, 2025 •
edited by danceratopz
Loading

🗒️ Description

The py_ecc dependency has been changed from a git dependency to a standard PyPI dependency. Since EEST indirectly depends on py_ecc through EELS it needs its EELS dependency bumped.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • Add CHANGELOG entry.

danceratopz
danceratopz requested changes Mar 13, 2025
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petertdavies Do you see any reason to not use ethereum-execution? The plan was to bump to this version:
https://pypi.org/project/ethereum-execution/1.17.0rc6.dev1/

We'll need to update uv.lock, too. I can handle it.

@danceratopz
Copy link
Member

@petertdavies Do you see any reason to not use ethereum-execution? The plan was to bump to this version: https://pypi.org/project/ethereum-execution/1.17.0rc6.dev1/

We'll need to update uv.lock, too. I can handle it.

This shouldn't be urgent as both ethereum and ethereum-spec-evm-resolver are pinned.

Afk, but if someone picks this up in the meantime: If we bump ethereum / ethereum-execution we'll need to bump the resolver to the latest version at the same time, too.

@petertdavies
Copy link
Contributor Author

This shouldn't be urgent as both ethereum and ethereum-spec-evm-resolver are pinned.

ethereum-spec-evm-resolver is not pinned. The entry in pyproject.toml is ethereum-spec-evm-resolver @ git+https://github.com/petertdavies/ethereum-spec-evm-resolver.

I've been developing some BLS tests as a separate python project which depends on execution-spec-tests. This mostly works, I will make an issue with the minor issues I encountered doing this. When I updated the py-ecc dependency in ethereum-spec-evm-resolver it broke that project.

@danceratopz
Copy link
Member

This shouldn't be urgent as both ethereum and ethereum-spec-evm-resolver are pinned.

ethereum-spec-evm-resolver is not pinned. The entry in pyproject.toml is ethereum-spec-evm-resolver @ git+https://github.com/petertdavies/ethereum-spec-evm-resolver.

Thanks for reporting - it should be. Repinned.

@danceratopz danceratopz added type:chore Type: Chore scope:fill Scope: fill command scope:deps Scope: Updates package dependencies labels Mar 13, 2025
danceratopz
danceratopz approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We just need to do fixture diff using hasher to main for pre-Prague forks before merging.

@danceratopz danceratopz requested a review from spencer-tb March 13, 2025 16:46
@spencer-tb
Copy link
Contributor

Checking now!

spencer-tb
spencer-tb approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@spencer-tb spencer-tb merged commit e04edbe into ethereum:main Mar 13, 2025
11 checks passed
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
@petertdavies @danceratopz @felix314159
chore(deps): Bump EELS dependency (ethereum#1310)
5a9f021 
* Bump EELS dependency

* Change EELS dep version in other location

* chore(deps): move from ethereum git to ethereum-execution package; bump resolver

* chore(deps): bump execution-specs version used for test fixture generation

* docs: update changelog

---------

Co-authored-by: danceratopz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

@danceratopz danceratopz danceratopz approved these changes

Assignees
No one assigned
Labels
scope:deps Scope: Updates package dependencies scope:fill Scope: fill command type:chore Type: Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petertdavies @danceratopz @spencer-tb