Skip to content

fix(consume): fixes for index generation with ethereum/tests #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2025

Conversation

danceratopz
Copy link
Member

🗒️ Description

Two small fixes for index generation with ethereum/tests:

  1. Allow index generation at any level of the directory structure by removing the relative path prefixes to fixtures that aren't supported. Only check their names (they have unique names). This allows uv run genindex -i ethereum/tests/BlockchainTests/some/path. Note, we can't load ethereum/tests state tests yet, only blockchain tests.
  2. Include the ethereum/tests info_[generatedTestHashasfixture_hash. This is not ideal, due to the info field name mismatch and as EEST fixture hashes are "0x" prefixed and ethereum/tests hashes aren't. But, it will at least allow verification that individual fixture files are up-to-date (this will not affect index.json regeneration, as this depends entirely on hasher`).

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.

@danceratopz danceratopz added type:bug Something isn't working scope:consume Scope: Consume command suite labels Mar 12, 2025
@danceratopz danceratopz force-pushed the consume-for-ethereum-tests branch from da79638 to 157909c Compare March 12, 2025 12:05
@danceratopz danceratopz requested a review from winsvega March 12, 2025 12:05
@winsvega
Copy link
Contributor

is it better to remove bigint tests to a separate category. because skip list is intrinsic

These experimental fixtures have been removed from the standard ethereum/tests test suite.
@winsvega
Copy link
Contributor

ethereum/tests#1470

@winsvega winsvega merged commit fa17151 into main Mar 12, 2025
21 checks passed
@winsvega winsvega deleted the consume-for-ethereum-tests branch March 12, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:consume Scope: Consume command suite type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants