Skip to content

chore(fill): fix for geth transition tool #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

lightsing
Copy link
Contributor

@lightsing lightsing commented Mar 3, 2025

🗒️ Description

When running fill with the geth transition tool we get the following error:

tests/shanghai/eip3855_push0/test_push0.py:145: in test_push0_contract_during_call_contexts
    state_test(env=env, pre=pre, post=post, tx=tx)
src/pytest_plugins/filler/filler.py:707: in __init__
    _info_metadata=t8n._info_metadata,
E   AttributeError: 'GethTransitionTool' object has no attribute '_info_metadata'

This is because GethTransitionTool does not init the parent class TransitionTool.

🔗 Related Issues

N/A

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@lightsing lightsing force-pushed the fix/geth-transition-tool branch from fc2c0ea to 06a6026 Compare March 3, 2025 04:41
@spencer-tb spencer-tb added type:chore Type: Chore scope:fill Scope: fill command labels Mar 14, 2025
@spencer-tb spencer-tb changed the title fix: GethTransitionTool did not init TransitionTool chore(fill): fix for geth transition tool Mar 14, 2025
@spencer-tb
Copy link
Contributor

Thanks! Could you please rebase on main and bump the changelog item to the unreleased version - one version up?

The lint error will additionally need to be fixed. Please run uvx --with=tox-uv tox -e lint locally to reproduce the errors in CI.

@lightsing lightsing force-pushed the fix/geth-transition-tool branch from d9c1cd0 to bdee5af Compare March 17, 2025 06:11
@lightsing
Copy link
Contributor Author

Thanks! Could you please rebase on main and bump the changelog item to the unreleased version - one version up?

The lint error will additionally need to be fixed. Please run uvx --with=tox-uv tox -e lint locally to reproduce the errors in CI.

done

Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@spencer-tb spencer-tb merged commit b07a88f into ethereum:main Mar 17, 2025
11 checks passed
@lightsing lightsing deleted the fix/geth-transition-tool branch March 18, 2025 05:13
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fill Scope: fill command type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants