Skip to content

new(tests) EIP-7698 failed nonce and short data tests #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

shemnon
Copy link
Collaborator

@shemnon shemnon commented Feb 13, 2025

🗒️ Description

Test two inbound cases, one where the deploy fails, then verifying the nonce is not incremented. The next with a "short data" subcontainer.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

shemnon and others added 2 commits February 12, 2025 18:31
Test two inbound cases, one where the deploy fails, then verifying the
nonce is not incremented. The next with a "short data" subcontainer.

Signed-off-by: Danno Ferrin <[email protected]>
@marioevz
Copy link
Member

@shemnon Created a PR to your PR over here: shemnon#8

new(tests): Add test cases to test_invalid_container
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marioevz marioevz merged commit 464292a into ethereum:main Feb 14, 2025
11 checks passed
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
* new(tests) EIP-7698 failed nonce and short data tests

Test two inbound cases, one where the deploy fails, then verifying the
nonce is not incremented. The next with a "short data" subcontainer.

Signed-off-by: Danno Ferrin <[email protected]>

* new(tests): Add test cases to test_invalid_container

---------

Signed-off-by: Danno Ferrin <[email protected]>
Co-authored-by: Mario Vega <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants